emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Re: ox-latex table tabbing support.


From: Kyle Meyer
Subject: Re: [PATCH] Re: ox-latex table tabbing support.
Date: Sun, 26 Jun 2022 14:18:02 -0400

Thanks for the follow-up patch.

Daniel Fleischer writes:

> Subject: [PATCH] lisp/ox-latex.el: tabbing code refactor
>
> * lisp/ox-latex.el: documentation, indentation, cleaning
> (org-latex-table)
> (org-latex--align-string-tabbing)
> (org-table--org-tabbing)

This format doesn't quite align to the conventions.  Here are two
examples:

,----[ https://orgmode.org/worg/org-contribute.html#commit-messages ]
|  * lisp/org-capture.el (org-capture-set-plist): Make sure txt is a
|  string before calling `string-match'.
|  (org-capture-templates): Fix customization type.
`----

,----[ 
https://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html#Style-of-Change-Logs
 ]
| * lisp/term.el (term-emulate-terminal): Avoid errors if the whole
| decoded string is eight-bit characters.  Don't attempt to save the
| string for next iteration in that case.
| * test/lisp/term-tests.el (term-decode-partial)
| (term-undecodable-input): New tests.
`----

[...]
> +  (or (org-export-read-attribute :attr_latex table :align)
> +      (let* ((count
> +              ;; Count the number of cells in the first row.
> +              (length
> +               (org-element-map
> +                   (org-element-map table 'table-row
> +                     (lambda (row)
> +                       (and (eq (org-element-property :type row)
> +                                'standard)
> +                            row))
> +                     info 'first-match)
> +                   'table-cell
> +                 (lambda (cell) cell))))

Fine as is, but (lambda (cell) cell) could be reduced to #'identity

> +             ;; Calculate the column width, using a proportion of
> +             ;;the documets textwidth.

nit: missing space before "the"

typo: documets -> document's

> +(defun org-table--org-tabbing (table contents info)
> +  "Return tabbing environment latex code for Org table.

Perhaps s/latex/LaTeX/ for consistency?

Otherwise, looks good to me.  Thanks again.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]