Re: [PATCH] describe how to override Author

[Ihor Radchenko]

Robert Pluim <rpluim@gmail.com> writes:

>>>>>> On Thu, 30 Jun 2022 21:19:36 +0800, Ihor Radchenko <yantar92@gmail.com> 
>>>>>> said:
>
>     Ihor> Robert Pluim <rpluim@gmail.com> writes:
>     >> >> Occasional committers would probably not read org-maintenance.org, 
> and
>     >> >> those are the people this section is aimed at, I think. Plus itʼs 
> the
>     >> >> kind of thing you need to catch early: once the commit has been 
> pushed
>     >> >> itʼs too late.
>     >> 
>     Ihor> Not really. org-contribute.org is the page directly linked from
>     Ihor> orgmode.org. It is aiming for new contributors with no write access.
>     >> 
>     >> This particular change is in "Your first commit as an Org
>     >> maintainer". Perhaps that node should be moved to org-maintenance.org?
>
>     Ihor> I do not think so. I am seeing this section as a "crash course" for 
> the
>     Ihor> new maintainers. We should only provide the critical information 
> there.
>     Ihor> Not too much, not too less. Something to not scare people with the
>     Ihor> details.
>
> I guess we disagree about whether knowing about the distinction
> between 'Author:' and 'Commit:' is critical or not. For a free
> software project correct attribution of changes is very important, so
> committers should pay attention to it (and by extension the
> documentation should educate them about it at the earliest
> opportunity). But youʼre the maintainer :-)

Maybe we are mis-communicating here.
AFAIU, carefully checking Author: and Commit: is only relevant when
applying commits made by people without commit access. Same goes for
checking the copyright status of the patch authors.

Occasional committers do not usually apply patches made by others.

>     Ihor> The elaborate details should be in org-maintenance.org, which is
>     Ihor> directly mentioned at the end of the "first commit" section.
>
> In "Where can I track bugs, patches and updates?" or somewhere else?

I think that "Copyright assignments" is suitable. "keep track of
copyright assignments" includes checking the copyright status of the
patch authors.

> BTW, Iʼm having trouble parsing this sentence from there:
>
>     You don't much more: confirming bugs is a critical contribution.
>
> Thereʼs at least one word missing betweeen "donʼt" and "much" there.

Fixed. Should be
"You don't need to do much more: confirming bugs is a critical contribution."

Best,
Ihor