[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5] ol.el: add description format parameter to org-link-param
From: |
Hugo Heagren |
Subject: |
Re: [PATCH v5] ol.el: add description format parameter to org-link-parameters |
Date: |
Thu, 14 Jul 2022 14:08:34 +0100 |
Ihor Radchenko <yantar92@gmail.com> writes:
> Currently, the internal implementation will treat nil return value as if
> there was no :default-description and org-link-make-description-function
> were set to nil. We may probably document this. It sounds like a useful
> behavior.
I added some relevant documentation to the `:default-description' part
of the `org-link-parameters' docstring. I also changed the
previosly-failing test to expect the right value. All the tests pass
now.
> Could you also add the proper changelog entry for the test-ol.el
> file?
Think I've got this right now, and other formatting errors.
> unwind-protect is more suitable here and will lead to more concise
> code.
I didn't know about `unwind-protect', thanks! You're right, much better.
> I think that we should also document the new parameter in ORG-NEWS.
Done.
Thanks, Hugo
0001-ol.el-add-description-format-parameter-to-org-link-p.patch
Description: Text Data
0002-test-ol-tests-for-default-description-param-when-ins.patch
Description: Text Data
- [PATCH v4] ol.el: add description format parameter to org-link-parameters, Hugo Heagren, 2022/07/07
- Re: [PATCH v4] ol.el: add description format parameter to org-link-parameters, Ihor Radchenko, 2022/07/08
- Re: [PATCH v5] ol.el: add description format parameter to org-link-parameters,
Hugo Heagren <=
- Re: [PATCH v5] ol.el: add description format parameter to org-link-parameters, Ihor Radchenko, 2022/07/17
- Re: [PATCH v6] ol.el: add description format parameter to org-link-parameters, Hugo Heagren, 2022/07/17
- Re: [PATCH v6] ol.el: add description format parameter to org-link-parameters, Max Nikulin, 2022/07/18
- Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters, Hugo Heagren, 2022/07/23
- Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters, Max Nikulin, 2022/07/23
- Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters, Ihor Radchenko, 2022/07/23