[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5] ol.el: add description format parameter to org-link-param
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH v5] ol.el: add description format parameter to org-link-parameters |
Date: |
Sun, 17 Jul 2022 18:27:05 +0800 |
Max Nikulin <manikulin@gmail.com> writes:
> Ihor, Hugo raised a question how to interpret nil returned by
> :insert-description functions. Do you have any opinion? I do not like
> the idea to consider it as an error since string is expected. I would
> prefer to call `org-link-make-description-function' as a fallback.
>
> On 17/07/2022 04:20, Hugo Heagren wrote:
>>> Can you also update the documentation for
>>> org-link-make-description-function?
>>
>> I'm not sure what sort of documentation you have in mind? What should
>> I add?
>
> I have no idea what Ihor means. From my point of view, mention of
> :insert-description and `org-link-parameters' may give a hint to users.
Let me clarify.
The new :insert-description parameter is a more fine-grained equivalent
to already existing org-link-make-description-function. The latter can,
de facto, return string or nil - it is passed to `read-string' as
INITIAL-INPUT argument.
So, I suggested interpreting nil return value in :insert-description
just as it is already interpreted in org-link-make-description-function.
Further, I asked to document that nil value is allowed - both in
:insert-description docstring section and in
org-link-make-description-function docstring.
Best,
Ihor
- [PATCH v4] ol.el: add description format parameter to org-link-parameters, Hugo Heagren, 2022/07/07
- Re: [PATCH v4] ol.el: add description format parameter to org-link-parameters, Ihor Radchenko, 2022/07/08
- Re: [PATCH v5] ol.el: add description format parameter to org-link-parameters, Hugo Heagren, 2022/07/14
- Re: [PATCH v5] ol.el: add description format parameter to org-link-parameters, Ihor Radchenko, 2022/07/17
- Re: [PATCH v6] ol.el: add description format parameter to org-link-parameters, Hugo Heagren, 2022/07/17
- Re: [PATCH v6] ol.el: add description format parameter to org-link-parameters, Max Nikulin, 2022/07/18
- Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters, Hugo Heagren, 2022/07/23
- Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters, Max Nikulin, 2022/07/23
- Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters, Ihor Radchenko, 2022/07/23
- Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters, Max Nikulin, 2022/07/23
- Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters, Max Nikulin, 2022/07/24
- Re: [PATCH v7] ol.el: add description format parameter to org-link-parameters, Ihor Radchenko, 2022/07/24
- Re: [PATCH v8] ol.el: add description format parameter to org-link-parameters, Hugo Heagren, 2022/07/25