[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Poly
From: |
Ihor Radchenko |
Subject: |
Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists |
Date: |
Tue, 26 Jul 2022 19:58:57 +0800 |
Juan Manuel Macías <maciaschain@posteo.net> writes:
> Here is the new patch. I have realized that it is not necessary to put a
> cond, since in this case it is only necessary to obtain the name of the
> language for the metadata, so this new patch is simpler.
Thanks for the update!
The patch has some misplaced parenthesis.
> - (let ((language (let ((lang (plist-get info :language)))
> - (or (cdr (assoc-string lang org-latex-babel-language-alist
> t))
> - (nth 1 (assoc-string lang
> org-latex-polyglossia-language-alist t))
> - lang))))
> + (let ((language (let ((lang (plist-get info :language))
> + ;; Here it would suffice to obtain the second
> + ;; element, which always returns the name
> + ;; language name in `org-latex-language-alist'
> + (nth 1 (assoc-string lang org-latex-language-alist
> t))))))
Your (nth 1 ...) sexp is inside the let definition:
(let ((lang ...)
(nth 1 ..))
nil)
Please pay attention to the compiler warnings.
Also, the original code contained the clause:
(or (get lang from the alist1)
(get lang from the alist2)
lang ; Fallback to provided language if not known.
)
Your variant does not have the fallback part. Is it intentional?
Best,
Ihor
- Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, (continued)
- Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Ihor Radchenko, 2022/07/23
- BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Kai von Fintel, 2022/07/23
- Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Ihor Radchenko, 2022/07/23
- Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Kai von Fintel, 2022/07/23
- Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Ihor Radchenko, 2022/07/23
- Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Kai von Fintel, 2022/07/23
- Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Ihor Radchenko, 2022/07/23
- Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Juan Manuel Macías, 2022/07/23
- Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Ihor Radchenko, 2022/07/24
- Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Juan Manuel Macías, 2022/07/24
- Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists,
Ihor Radchenko <=
- Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Juan Manuel Macías, 2022/07/26
- Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Ihor Radchenko, 2022/07/28
- Re: BUG Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Juan Manuel Macías, 2022/07/23
- Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Juan Manuel Macías, 2022/07/23
- Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Ihor Radchenko, 2022/07/23
- Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Max Nikulin, 2022/07/23
- Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Ihor Radchenko, 2022/07/24
Re: [PATCH] ox-latex.el: Unify in one single list Babel and Polyglossia languages alists, Max Nikulin, 2022/07/10