emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3] Re: [BUG] org-attach-id-ts-folder-format fails on customi


From: Max Nikulin
Subject: Re: [PATCH v3] Re: [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)]
Date: Wed, 10 Aug 2022 22:18:18 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 10/08/2022 20:23, Ihor Radchenko wrote:
Max Nikulin writes:

+the path."
+  (if (< (length id) 3)
+      (format "--/%s" id)

Please, do not use path components starting with dash, it is terrible
for CLI tools. By the way, you promised underscores, not dashes.

Why?

It is inconvenient in interactive sessions (in scripts appropriate measures must be taken anyway), the following does not list content of the "--" directory:

    ls -l --

I slightly dislike the "___xx" compared to "______" because it will
create a proliferation of top-level folders as opposed to cramping the
non-standard IDs into a single "______" folder.

I believed that proliferation of folders is for purpose. Intermediate directories allows to avoid excessive number of files in single directory. ext4 with directory tree index usually is not the case, but other filesystems may have rather poor performance when too much files are stuffed into single folder. Some applications become really slow for huge directories.

On the other hand there are not so many distinct file names that may fall into "__" directory, so perhaps it is OK. Concerning "unknown" I am less sure.

I do not have strong opinion how to properly deal with short IDs.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]