Re: [PATCH v3] ol-info: Define :insert-description function

[Ihor Radchenko]

Max Nikulin <manikulin@gmail.com> writes:

> On 22/08/2022 11:10, Ihor Radchenko wrote:
>> 
>> Maybe, in addition to "Return cons consisting of file name and node name",
>> you can put something like "File name may also be a virtual file name
>> (see `Info-virtual-files')."
>
> I have tried to fix docstrings.

Thanks! LGTM now.
Applied onto main via 372788a18.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=372788a18933b9ed38b747e5f5429ea39d71106a

>> I am ok with current behavior. It is only the docstring that I find
>> slightly confusing.
>
> I am still unsure how to treat links with missed filename, so I changed 
> it from "(org) Something" to "(dir) Something". The latter is not valid, 
> but it is more consistent with "(dir) Top" for "info:" (empty path) links.

Let's not overthink edge cases. Unless we can reasonably expect some
specific invalid links in the wild, there is no reason to be too smart
here.

-- 
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92