[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] org.el: Preserve case for link subgroups from `org-file-a
|
From: |
Ihor Radchenko |
|
Subject: |
Re: [PATCH v2] org.el: Preserve case for link subgroups from `org-file-apps' |
|
Date: |
Fri, 09 Sep 2022 19:10:49 +0800 |
Max Nikulin <manikulin@gmail.com> writes:
> Evey attempt to read this function gives a new surprise. I agree that
> dlink has no sense any more, see the new patches.
Thanks!
Applied onto main.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=33686b9955c011486a72ec548475651dcadb0339
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6e9ea3a0766de9df6992bfb0359a5826ed1951b5
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f25b308af671766bb01e507c6db57bf3e83d8d05
>> So, it is probably safe to drop it, especially if tests are passing.
>
> There is no tests for `org-open-file'. Checking of file existence,
> running an asynchronous process make it harder to create such tests.
We need mocking, I guess (aka cl-letf).
--
Ihor Radchenko,
Org mode contributor,
Learn more about Org mode at https://orgmode.org/.
Support Org development at https://liberapay.com/org-mode,
or support my work at https://liberapay.com/yantar92