emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] ol.el: Always prompt for description in `org-insert-link'


From: Max Nikulin
Subject: [PATCH] ol.el: Always prompt for description in `org-insert-link'
Date: Wed, 14 Sep 2022 23:11:29 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

Hi,

The `org-insert-link' function has the `auto-desc' variable to suppress user prompt for link description. It worked accordingly its intention (as I understand it) a couple of months a decade ago, after that the logic was broken. Actually the behavior is rather strange: users may edit description only when it is not identical to link path (target). I am attaching a patch that removes this variable with hope that always prompting the user for description is more consistent behavior.

Actually during last week completion stored link by its description has been restored, storing link has been changed to prefer nil as description to the path when nothing meaningful may be added. So behavior have become more close to original one.

I have an idea how to fix the code to bypass the description prompt if path is completed by description discarding identical path and description, but I prefer to drop the confusing variable and not depend on the means how the link was selected from the list of stored items.

Have I missed something and unconditional prompt to edit link description may be undesired in some cases?

Attachment: 0001-ol.el-Always-prompt-for-description-in-org-insert-li.patch
Description: Text Data

Attachment: 0002-ol.el-Mention-that-org-insert-link-may-edit-existing.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]