[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Use lexical-scoping in tests
From: |
Stefan Monnier |
Subject: |
Re: Use lexical-scoping in tests |
Date: |
Wed, 14 Sep 2022 14:23:59 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
Ihor Radchenko [2022-09-14 20:32:53] wrote:
> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> The patch below simply enables `lexical-binding` in all the test files.
>> As far as I can tell, it's all that's needed (beside a missing
>> `require`).
> Thanks, but the patch causes 23 tests to fail (running make test).
Oh, lord!
The fix is in preparation, but obviously I had tested my patch
incorrectly (i.e. I probably compiled and tested another code than the
one I had patched).
[ At least it explains why I was seeing this weird "it's all that's
needed", which I always hope for but is so rarely true. ]
> Also, is there any reason why it was a plain diff?
Lack of inspiration, mostly.
Stefan