emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4] [BUG] org-attach-id-ts-folder-format fails on customized


From: Max Nikulin
Subject: Re: [PATCH v4] [BUG] org-attach-id-ts-folder-format fails on customized IDs [9.6 (9.6-??-2e9999783)]
Date: Tue, 4 Oct 2022 22:27:29 +0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 02/10/2022 16:14, Ihor Radchenko wrote:
Ihor Radchenko writes:
Max Nikulin writes:

The new version of the patch allows all but first function return nil.
See the attached.

Let me know if there are any other objections.

Ihor, sorry that I left your earlier questions with no response. I hope, the attached diff may illustrate my ideas better. I have not tried to run it though, so it can be full of stupid mistakes. I suggest to ignore nil values completely, but maybe I missed some use case.

Actually I suspect the if the `org-attach-dir-from-id' function returned both first and existing directories, the code of callers would be clearer.

Attachment: alt-org-attach-id-dir.diff
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]