[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] Allow returning empty list from post-processing block
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH 1/1] Allow returning empty list from post-processing block |
Date: |
Thu, 06 Oct 2022 11:15:14 +0800 |
Jonas Bernoulli <jonas@bernoul.li> writes:
> * lisp/ob-ref.el (org-babel-ref-resolve): When the result an empty
> list, then treat it as a list, not as the symbol nil.
> * testing/lisp/test-ob.el (test-ob/return-empty-list-from-post-block):
> Add new test.
> * etc/ORG-NEWS (Post-processing code blocks can return an empty list):
> Document change in behavior.
Thanks for the patch!
LGTM in general.
>
> +(ert-deftest test-ob/return-empty-list-from-post-block ()
Re: test location. Should probably be around
`test-ob/elisp-in-header-arguments'.
Also, I'd slightly prefer to have a more general test name like
test-ob/post-header-argument. We may add more cases inside later.
I have no comments wrt the code in the commit.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>