Re: [PATCH] (v2) Fix void variable error `cider-buffer-ns` when specifying :backend header argument

[Christopher M. Miles]

Ihor Radchenko <yantar92@gmail.com> writes:

> "Christopher M. Miles" <numbchild@gmail.com> writes:
>
>> After updated to latest commit, I found error,
>>
>> Reproduce:
>>
>> When I specified the `:backend` header argument:
>>
>> #+begin_src clojure :backend babashka
>> (+ 2 4)
>> #+end_src
>>
>> I got error:
>>
>> #+begin_example
>> void variable: cider-buffer-ns
>> #+end_example
>
> Thanks for reporting!
>
>> Here is the patch fix upper issue.
>>
>>    (let* ((vars (org-babel--get-vars params))
>> +         (backend-override (cdr (assq :backend params)))
>>       (ns (or (cdr (assq :ns params))
>> -             (if (eq org-babel-clojure-backend 'cider)
>> +             (if (and (not backend-override)
>> +                          (eq org-babel-clojure-backend 'cider))
>>                   (or cider-buffer-ns
>>                       (let ((repl-buf (cider-current-connection)))
>>                         (and repl-buf (buffer-local-value
>
> What if backend-override is 'cider?
> I suggest to let-bind
> (org-babel-clojure-backend
>           (cond
>            (backend-override (intern backend-override))
>            (org-babel-clojure-backend org-babel-clojure-backend)
>            (t (user-error "You need to customize `org-babel-clojure-backend'
> or set the `:backend' header argument"))))
>
> Just like in `org-babel-execute:clojure'.

You're right, updated now.

0001-lisp-ob-clojure.el-Fix-backend-override-not-work-wit.patch
Description: Text Data

-- 

[ stardiviner ]
I try to make every word tell the meaning that I want to express without 
misunderstanding.

Blog: https://stardiviner.github.io/
IRC(libera.chat, freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3

signature.asc
Description: PGP signature