emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add light argument to org-babel-lob-get-info


From: Ihor Radchenko
Subject: Re: [PATCH] Add light argument to org-babel-lob-get-info
Date: Mon, 17 Oct 2022 09:10:15 +0000

Ferdinand Pieper <fer@pie.tf> writes:

> Similar to ~org-babel-get-src-block-info~ it is sometimes useful to disable 
> evaluation of lisp parameters when getting the info of a lob call. This patch 
> adds an argument for that.
>
> Better name for the argument could be ~no-eval~, but I decided to stick with 
> the naming in ~org-babel-get-src-block-info~. To be completely consistent 
> with ~org-babel-get-src-block-info~ the argument order could be swapped, but 
> this would break existing function calls. 
>
> What do you think?

I see no problem with this addition.

I'd prefer to change LIGHT to NO-EVAL, including in
org-babel-get-src-block-info. Changing argument name in function does
not affect its caller in any way. Just need to update the function body
and docstring carefully.

NO-EVAL is already used by org-babel-parse-header-arguments and
org-babel-params-from-properties.

May I know if you are proposing this for a specific purpose?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]