Re: [PATCH v2 1/2] lisp/org-clock.el: Make switching states on clock-in/-out easier

[Ihor Radchenko]

"Samuel W. Flint" <swflint+orgmode@flintfam.org> writes:

> * lisp/org-clock.el (org-clock-in-switch-to-state,
> org-clock-out-switch-to-state): Allow
> `org-clock-{in,out}-switch-to-state` to be an alist of
> current/next-state pairs.
>
> (org-clock-in, org-clock-out): Add logic to handle
> `org-clock-{in,out}-switch-to-state` as alists.

Thanks!

Before we continue, could you please confirm if you have FSF copyright
assignment? My records show that you have made two commits to Org mode
previously, and they total LOC is 15, which is maximum allowed
contribution that does not require copyright assignment. See
https://orgmode.org/worg/org-contribute.html#copyright

>    "Set task to a special todo state while clocking it.
>  The value should be the state to which the entry should be
> -switched.  If the value is a function, it must take one
> -parameter (the current TODO state of the item) and return the
> -state to switch it to."
> +switched.  It may also be an alist of `(CURRENT . NEXT)' pairs.

Maybe "`(CURRENT . NEXT)' TODO state pairs"? It will be slightly more
clear.

>  (defcustom org-clock-out-switch-to-state nil
>    "Set task to a special todo state after clocking out.
>  The value should be the state to which the entry should be
> -switched.  If the value is a function, it must take one
> -parameter (the current TODO state of the item) and return the
> -state to switch it to."

Same here.

The rest looks good.

If you can, please also add tests.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>