Re: [PATCH] lisp/ob-tangle.el, lisp/ob-core.el: Add strip-tangle noweb option

[Daniel Ziltener]

Am 28.10.22 um 04:19 schrieb Ihor Radchenko:
> dziltener@lyrion.ch writes:
>
> > From: Daniel Ziltener <dziltener@lyrion.ch>
> >
> > * ob-tangle.el, ob-core.el, test-ob-tangle.el, org-manual.org: Add a
> > "strip-tangle" noweb option to strip the noweb tags when tangling, but
> > keep and expand them otherwise.
> Thanks for the patch!
>
> If I understand correctly, you are suggesting
>
> Could you please follow
> https://orgmode.org/worg/org-contribute.html#commit-messages for the
> commit log entries?
I tried to follow that. To follow it "more" I guess I have to make one 
commit per file I changed? There isn't an example for multiple files, so 
I was not sure how exactly to follow it.
> Also, do you have FSF copyright assignment? If no, you also need to add
> TINYCHANGE cookie to the commit message. See
> https://orgmode.org/worg/org-contribute.html#first-patch
I do, yes, I sent in the signed form on Wednesday as requested by the FSF.
> > +- =strip-tangle= ::
> > +
> > +  Expansion of noweb syntax references in the body of the code block
> > +  when evaluating or exporting. Removes noweb syntax references
> > +  when tangling.
> This is a new feature and thus should also be mentioned in etc/NEWS.
>
> Also, please use double space between sentences. See
> doc/Documentation_Standards.org.
Noted, I'll do both of these.
> >     (let ((allowed-values (cl-case context
> > -                         (:tangle '("yes" "tangle" "no-export" "strip-export"))
> > -                         (:eval   '("yes" "no-export" "strip-export" "eval"))
> > -                         (:export '("yes")))))
> > +                         (:tangle '("yes" "tangle" "no-export" "strip-export" 
> > "strip-tangle"))
> > +                         (:eval   '("yes" "no-export" "strip-export" "eval" 
> > "strip-tangle"))
> > +                         (:export '("yes" "strip-tangle")))))
> AFAIU, you are suggesting a new value for :noweb header argument.
> But this function has nothing to do with :noweb. This change will check
> for :tangle strip-tangle, :eval strip-tangle, and :export strip-tangle.
> What is the purpose?
I suppose then I made a mistake there. My intention was what you mention 
next:
> Also, the allowed values of standard header args are defined in
> org-babel-common-header-args-w-values, which you did not change.
I will adjust that one instead.

OpenPGP_0x752C7F031AADF16F.asc
Description: OpenPGP public key

OpenPGP_signature
Description: OpenPGP digital signature