[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fix ob-clojure handling source block variable's value is a o
From: |
Ihor Radchenko |
Subject: |
Re: [PATCH] Fix ob-clojure handling source block variable's value is a org-mode table or list |
Date: |
Sat, 29 Oct 2022 05:56:32 +0000 |
"Christopher M. Miles" <numbchild@gmail.com> writes:
> Any review comments about this patch?
I have sent the following comment shortly after your followup:
"Christopher M. Miles" <numbchild@gmail.com> writes:
> + ;; variable's value is a list from org-mode passed table
> or list.
> + (if (listp (cdr (car vars)))
> ...
> + (format "(let [%s]\n%s)"
> + (mapconcat
> + (lambda (var)
> + (format "%S '%S" (car var) (cdr var)))
> + vars
> + "\n ")
Do I miss something, or you only test the first variable assignment here?
What if there are multiple assignments (:var a=X,b=Y)?
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>