emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] org-babel-insert-result: Fix wrong-type-argument markerp nil


From: Ihor Radchenko
Subject: Re: [PATCH] org-babel-insert-result: Fix wrong-type-argument markerp nil
Date: Wed, 09 Nov 2022 06:42:58 +0000

Bruno Barbier <perso.bruno.barbier@free.fr> writes:

>> Thanks, but could you please explain a bit more about this corner case?
>
>> `end' must be always defined because
>> (setq end (copy-marker (point) t))
>> must be executed.
>
> If the body of the unwind-protect throw an error, the variable 'end'
> might still be nil. It's set to nil when declared with the 'let' form.

Good point. Then, I agree that the patch can be merged as is.
Applied onto main amending the commit message.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=7f72807aead9c350d85513702deb04722b65a25b

>> Your patch, if addressing a valid scenario, is not treating the root
>> cause; just the symptom.
>
> You're right. I was investigating an other bug. That
> 'wrong-type-argument markerp nil' was just hiding the real bug to me.

Let us know once you gather enough details.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]