[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Babel (scheme): Evaluation errors are not shown
From: |
Ihor Radchenko |
Subject: |
Re: Babel (scheme): Evaluation errors are not shown |
Date: |
Sat, 31 Dec 2022 13:24:36 +0000 |
Marc Nieper-Wißkirchen <marc@nieper-wisskirchen.de> writes:
> Please find the patch file attached to this email.
Thanks!
I will give some general comments and leave the ob-scheme changes for
Rudolf.
> Subject: [PATCH] Display evaluation errors for Scheme code blocks.
If you can, please provide changelog entries explaining each change. See
https://orgmode.org/worg/org-contribute.html#commit-messages
> (let ((buf (get-buffer-create org-babel-error-buffer-name)))
> (with-current-buffer buf
> (goto-char (point-max))
> (save-excursion
> (unless (bolp) (insert "\n"))
> (insert stderr)
> - (insert (format "[ Babel evaluation exited with code %S ]"
> exit-code))))
> + (when exit-code
> + (insert (format "[ Babel evaluation exited with code %S ]"
> exit-code)))))
I think it will be more consistent to do something like
(if exit-code ... (insert " [ Babel evaluation exited abnormally ] "))
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>
- Babel (scheme): Evaluation errors are not shown, Marc Nieper-Wißkirchen, 2022/12/16
- Re: Babel (scheme): Evaluation errors are not shown, Ihor Radchenko, 2022/12/18
- Re: Babel (scheme): Evaluation errors are not shown, Rudolf Adamkovič, 2022/12/19
- Re: Babel (scheme): Evaluation errors are not shown, Marc Nieper-Wißkirchen, 2022/12/20
- Re: Babel (scheme): Evaluation errors are not shown, Ihor Radchenko, 2022/12/31
- Re: Babel (scheme): Evaluation errors are not shown, Marc Nieper-Wißkirchen, 2022/12/31
- Re: Babel (scheme): Evaluation errors are not shown, Marc Nieper-Wißkirchen, 2022/12/31
- Re: Babel (scheme): Evaluation errors are not shown, Marc Nieper-Wißkirchen, 2022/12/31
- Re: Babel (scheme): Evaluation errors are not shown, Ihor Radchenko, 2022/12/31
- Re: Babel (scheme): Evaluation errors are not shown, Marc Nieper-Wißkirchen, 2022/12/31
- Re: Babel (scheme): Evaluation errors are not shown,
Ihor Radchenko <=
- Re: Babel (scheme): Evaluation errors are not shown, Marc Nieper-Wißkirchen, 2022/12/31
- Re: Babel (scheme): Evaluation errors are not shown, Ihor Radchenko, 2022/12/21
- Re: Babel (scheme): Evaluation errors are not shown, Bastien Guerry, 2022/12/29