emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] org-datetree.el: Allow datetrees with TODO, priority, tags


From: Ilya Chernyshov
Subject: Re: [PATCH] org-datetree.el: Allow datetrees with TODO, priority, tags
Date: Wed, 11 Jan 2023 16:59:26 +0600
User-agent: mu4e 1.8.13; emacs 30.0.50


Ihor Radchenko <yantar92@posteo.net> writes:

Ilya Chernyshov <ichernyshovvv@gmail.com> writes:

 (defun org-datetree--find-create
@@ -169,18 +167,19 @@ component. If INSERT is non-nil and there is no match then it is
 inserted into the buffer."
   (when (or month day)
     (org-narrow-to-subtree))
-  (let ((re (format regex-template year month day))
+  (let ((re (format org-complex-heading-regexp-format
+                    (format regex-template year month day)))

These changes make the docstring for `org-datetree--find-create'
incorrect:

    (defun org-datetree--find-create
        (regex-template year &optional month day insert)
"Find the datetree matched by REGEX-TEMPLATE for YEAR, MONTH, or DAY. REGEX-TEMPLATE is passed to `format' with YEAR, MONTH, and DAY as arguments. Match group 1 is compared against the specified date component. If INSERT is non-nil and there is no match then it is
    inserted into the buffer."

Please update the docstring to reflect the new behaviour.

Changed the docs, please review the new patch.

Attachment: 0001-lisp-org-datetree.el-Allow-datetrees-with-TODO-prior.patch
Description: Text Data


--
Best,
Ilya

reply via email to

[Prev in Thread] Current Thread [Next in Thread]