Re: [PATCH] lisp/org-agenda.el: Fix void-function string-pad in Emacs <28.1

[Aaron Zeng]

Hi Ihor, I just noticed that this patch only fixes one of the lines calling `string-pad'.  There is another callsite below which needs to be removed.

On Tue, Jan 24, 2023 at 11:30 AM Aaron Zeng <me@bcc32.com> wrote:

Thanks for the quick response, Ihor!

On Tue, Jan 24, 2023 at 4:23 AM Ihor Radchenko <yantar92@posteo.net> wrote:

"Aaron L. Zeng" <me@bcc32.com> writes:

> * org-compat.el (org-string-pad): Add compatibility function
> `org-string-pad' for `string-pad', introduced in Emacs 28.1.
>
> * org-agenda.el (org-fix-agenda-info): Use `org-string-pad' rather
> than `string-pad'.
>
> Since this is more-or-less just copying string-pad's definition from
> subr-x.el, I think this qualifies for TINYCHANGE.

Thanks!
This issue has not been caught by byte-compilation.

I applied an alternative fix not using `string-pad' at all.
Canceled.

https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5bbb97f3df9788646b8d48d60e8b8ea06566e05f

--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>