Re: MPD player status change bug

[Ryan Van Wagoner]

I must apologize.

It turns out that I was misunderstanding the types of the arguments
for the run-at-time function. It turns out that the original code was
correct and that the problem was with my configuration on the MusicPD
side.

As pennance, I have attached the diff reverting to the correct form
and adding a short snippet to the info documentation explaining how to
avoid the behavior I was seeing.

I apologize again for any inconvenience to you or the users of this software.

Best regards,

Ryan

diff --git a/doc/emms.texinfo b/doc/emms.texinfo
index d3e30cf..5bd384d 100644
--- a/doc/emms.texinfo
+++ b/doc/emms.texinfo
@@ -2553,6 +2553,11 @@ should then be accessible via the Emms browser.
 You can set @var{emms-player-mpd-sync-playlist} to nil if your master
 Emms playlist contains only stored playlists.
 
+In order for Emms to synchronize track information correctly with
+MusicPD, you must set the MusicPD server runtime 'consume' option to
+'off'. This can be accomplished with the mpc command line MusicPD client
+using the command @command{mpc consume off}.
+
 @subheading Commands provided
 
 @defun emms-player-mpd-connect
diff --git a/emms-player-mpd.el b/emms-player-mpd.el
index 3267988..5ac48fa 100644
--- a/emms-player-mpd.el
+++ b/emms-player-mpd.el
@@ -873,7 +873,7 @@ playlist."
           (setq emms-player-mpd-current-song nil)
           (if emms-player-mpd-check-interval
               (setq emms-player-mpd-status-timer
-                    (run-at-time emms-player-mpd-check-interval t
+                    (run-at-time t emms-player-mpd-check-interval
                                  #'emms-player-mpd-detect-song-change))
             (emms-player-mpd-detect-song-change)))))
     ;; we only want to play one track, so don't start the timer
@@ -944,7 +944,7 @@ This is called if `emms-player-mpd-sync-playlist' is 
non-nil."
       (emms-player-mpd-detect-song-change info)
       (when emms-player-mpd-check-interval
        (setq emms-player-mpd-status-timer
-             (run-at-time emms-player-mpd-check-interval t
+             (run-at-time t emms-player-mpd-check-interval
                           #'emms-player-mpd-detect-song-change))))))
 
 ;;;###autoload

On Tue, Jan 25, 2022 at 10:27:16AM -0500, Yoni Rabkin wrote:
> 
> Apologies for not applying this earlier.
> 
> I've pushed this to elpa and in the repo as version 9. Please update and
> test.
> 
> Thank you for the bug report, and more importantly, the patch to fix it.
> 
> -- 
>    "Cut your own wood and it will warm you twice"