emms-help
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] lisp/emms-playlist-mode.el: Fix `emms-playlist-mode-go' to r


From: Yoni Rabkin
Subject: Re: [PATCH] lisp/emms-playlist-mode.el: Fix `emms-playlist-mode-go' to respect `emms-mark-mode'
Date: Tue, 28 Mar 2023 16:23:20 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)

Kierin Bell <fernseed@posteo.net> writes:

> lisp/emms-playlist-mode.el (emms-playlist-mode-go): Do not run
> `emms-playlist-mode' when `major-mode' is `emms-mark-mode'.
> ---
> This is a patch for another bug that causes `emms-playlist-mode-go' to 
> disable emms-mark-mode, which is not what users would probably expect.
>
>  emms-playlist-mode.el | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/emms-playlist-mode.el b/emms-playlist-mode.el
> index 9b1f047..cae985e 100644
> --- a/emms-playlist-mode.el
> +++ b/emms-playlist-mode.el
> @@ -510,7 +510,7 @@ When NO-NEWLINE is non-nil, do not insert a newline after 
> the track."
>         (not (buffer-live-p emms-playlist-buffer)))
>        (error "No current Emms buffer")
>      (switch-to-buffer emms-playlist-buffer)
> -    (when (and (not (eq major-mode 'emms-playlist-mode))
> +    (when (and (not (member major-mode '(emms-playlist-mode emms-mark-mode)))
>              emms-playlist-buffer-p)
>        (emms-playlist-mode))
>      (when emms-playlist-mode-center-when-go

Patched as well; thank you again.

Your name has been added to the AUTHORS file.

-- 
   "Cut your own wood and it will warm you twice"



reply via email to

[Prev in Thread] Current Thread [Next in Thread]