enigma-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Enigma-devel] game area alignment bug


From: Till Harbaum / Lists
Subject: [Enigma-devel] game area alignment bug
Date: Fri, 29 Feb 2008 22:23:16 +0100
User-agent: KMail/1.9.6 (enterprise 0.20070907.709405)

Hi,

i have taken a look at the 800x480 support for maemo. Everything but the game 
itself worked out of the box after changing the video mode description 
accordingly and after adding a 800x480 background image.

I expected the game itself to be left aligned since i didn't change anything 
in the game layout part of the video description. I was surprised to see that 
the statusbar was left aligned, but the game area was centered!

After some digging in the source code i think i found some minor bug causing 
this behaviour:

In GameDisplay::resize_game_area in display.cc the lines
     int screenw = vidinfo->width;
    int screenh = NTILESV * vidinfo->tile_size;
always use the entire screen for the game area. I think it would be correct to 
use
    int screenw = vidinfo->gamearea.w;
    int screenh = vidinfo->gamearea.h;
instead to place the game area inside it's specified area.

The above lines will give the same result on the existing modes but gives the 
expected left aligned display when using setups where the game area isn't as 
wide as the screen.

Till




reply via email to

[Prev in Thread] Current Thread [Next in Thread]