Re: fabric3

[Mathias Ertl]

Hi,

> On Tue, May 26, 2020 at 6:02 PM <za3k@za3k.com <mailto:za3k@za3k.com>>
> wrote:
>
>> Hi / tag Matthias! I've been talking to the fabric mailing list
>> (cc'd) and the fabric developer bitprophet (cc'd). The subject is
>> adding python3 support to fabric 1.x (even though 2.x is the latest) 
>> as part of making an official package.

That's good to hear, too many PRs by different people were rejected.

>> bitprophet, the current state is that this is forked off 1.14.0, only
>> one version behind the latest, and I see no feature additions or
>> changes. It's been marked DEPRECATED for a year because 2.x added
>> python3 support.

That's correct, TBH I didn't check out 2.x to closely because the 
company I'm working for now doesn't use it. I did assume feature parity.

>> mathiasertl, I'd like to merge your fabric3 work into fabric. No
>> issues, right?

No absolutely not (its Free Software after all ;-)). I am willing to 
make a PR myself (or more likely, multiple PRs) to get this going.


On 5/27/20 5:50 PM, Jeff Forcier wrote:
> - Fabric 1.15 was IIRC a single small feature-add, so if there are no 
> big changes on the fork besides just the Python 3 compatibility, 
> unifying them should still be relatively easy, mechanically speaking.

IIRC, I also did lots of flake8 cleanup in some versions, but later on 
didn't do it to have a lower maintenance burden.

> - As stated earlier on the list, my main concern with the Py3 compat is 
> that Fabric 1's test suite doesn't have as high a % coverage as I'd like 
> (one of many impetuses for v2) but at this point I'm guessing fabric3's 
> usage has been widespread enough, for long enough, that any serious bugs 
> have already been found.
>    - Curious what, if any, you ran into though - Paramiko went through 
> quite a lot of instability in its own Py3 journey...

I do think there are some issues left, but nothing out of the ordinary. 
I didn't see too many issues with it, BUT I only used a limited subset 
of it.


> - Re: the fabric3 name on pip - no rush on figuring that out, for 
> multiple reasons.
>    - At the VERY least we would need to wait til stats show most users 
> of fabric3 had migrated to either post-merge fabric1, or fabric2. Not in 
> a rush to pull the rug out from under anyone.
>    - I'm hoping that Fabric 3.x, 4.x etc will be non full rewrites and 
> thus there will be no need for in place side by side upgrades - which 
> was the only real reason to even need a 'fabric2' on pypi (and, thus, 
> ever a mainstream 'fabric3')
>    - By the time we get there I'd mostly be concerned about user 
> confusion (intending to get 'fabric==3.x' but installing 'fabric3' 
> instead) but that is likely a ways off!
>
> Best,
> Jeff
>
> On Tue, May 26, 2020 at 6:02 PM <za3k@za3k.com <mailto:za3k@za3k.com>> 
> wrote:
>
>     Hi / tag Matthias! I've been talking to the fabric mailing list (cc'd)
>     and the fabric developer bitprophet (cc'd). The subject is adding
>     python3 support to fabric 1.x (even though 2.x is the latest) as
>     part of
>     making an official package.
>
>     bitprophet, the current state is that this is forked off 1.14.0, only
>     one version behind the latest, and I see no feature additions or
>     changes. It's been marked DEPRECATED for a year because 2.x added
>     python3 support.
>
>     mathiasertl, I'd like to merge your fabric3 work into fabric. No
>     issues,
>     right?
>
>     Also, bitprophet has mentioned that might be helpful there wasn't a
>     pre-existing 'fabric3' pip package out of his control, in case of
>     future
>     difficulty/confusion with a fabric 3.0 release--I'll leave ya'll to
>     talk
>     that out.
>
>
>
> --
> Jeff Forcier
> Unix sysadmin; Python engineer
> http://bitprophet.org