Re: [Fenfire-dev] PEG imagescrollblock--humppake

[Tuomas Lukka]

I'm accepting this, but please read the comments and remember them.

On Fri, Sep 05, 2003 at 09:37:44AM +0300, Asko Soukka wrote:
> ==========================================================================
> PEG imagescrollblock--humppake: interface ImageScrollBlock
> ==========================================================================
> 
> :Authors:  Asko Soukka
> :Date-Created: 2003-09-03
> :Last-Modified: $Date: 2003/09/04 07:37:25 $
> :Revision: $Revision: 1.2 $
> :Status:   Current
> :Status:   Incomplete

Still two statuses??

> :Scope:    Minor
> :Type:     Interface
> 
> This PEG prososes a new Alph scrollblock type: ImageScrollBlock.
> ImageScrollBlock would be the interface for Alph scrollblocks
> containing only a single image.
> 
> Own scrollblock type for images is needed because handling images
> differ from handling any of the current scrollblock types. Therefore
> imagescrollblocks must be able to distinguish from other scrollblocks
> and they need their own type.

I had a comment about this: important to say *why* it's relevant now.

> Issues
> ======
> 
> Aren't current interfaces enough?
> 
>     RESOLVED: The currently existing scrollblock interfaces are
>     PageScrollBlock and TextScrollBlock, both extending the basic
>     ScrollBlock interface. TextScrollBlock is meant for text and
>     PageScrollBlock for PDF and PS documents.
>  
>     scrollblocks containing single images should be handled
>     separately from both the text scrollblocks and PDF/PS document
>     scrollblocks. Therefore, they need their own scrollblock
>     interface.
> 
> What spesific methods should the new interface provide?
> 
>     RESOLVED: None for now. The interface is currently needed only
>     to separate ImageScrollBlocks from other ScrollBlocks. New 
>     ImageScrollBlock spesific methods could be pegged later, if
>     found necessary.
> 
> Changes
> =======
> 
> Create the new interface ``org.nongnu.alph.ImageScrollBlock`` with no
> any methods.

With no method, not "with no any methods".

> Change SimpleImageScroll to implement the new interface. No changes
> into SimpleImageScroll's code is needed, since the interface doesn't
> present any new methods.

Accepted.

        Tuomas