Re: [PATCH] Introduce POOMA_MESSAGING

[Richard Guenther]

On Thu, 18 Dec 2003, Jeffrey D. Oldham wrote:

> Richard Guenther wrote:
> > Hi!
> >
> > This patch introduces POOMA_MESSAGING which is set for both Cheetah and in
> > future native MPI.  It also mechanically changes POOMA_CHEETAH to
> > POOMA_MESSAGING tests, where appropriate.  Also including of
> > Cheetah/Cheetah.h is exchanged for including Tulip/Messaging.h (which in
> > turn includes Cheetah/Cheetah.h and will include mpi.h for native MPI).
> >
> > Ok?
>
> Yes, but I have some questions ...
>
> > Richard.
> >
> >
> > 2003Dec18  Richard Guenther <address@hidden>
> >
> >     * configure: add POOMA_MESSAGING define, if Cheetah is configured.
> >     src/Domain/Grid.h: change #if POOMA_CHEETAH to #if POOMA_MESSAGING
> >     where appropriate, #include Tulip/Messaging.h rather than
> >     Cheetah/Cheetah.h.
> >     src/Tulip/Messaging.h: likewise.
>
> There seems to be Cheetah code surrounded by POOMA_MESSAGING.  Is this
> correct?
>
> >     src/Tulip/PatchSizeSyncer.cmpl.cpp: likewise.
>
> This may need changing if the next file is changed.
>
> >     src/Tulip/PatchSizeSyncer.h: likewise, remove unused declarations.
>
> Same question as for src/Tulip/Messaging.h.

Ah yes, I should have mentioned that the native MPI implementation shares
the Cheetah::Serialize classes with Cheetah.  This minimizes necessary
changes and was the least hassle.  I'm going to add the
MatchingHandler/Serialize.h file from the Cheetah distribution as
Tulip/CheetahSerialize.h - but maybe we should check the license first.

Ok with this clarification?

Richard.

--
Richard Guenther <richard dot guenther at uni-tuebingen dot de>
WWW: http://www.tat.physik.uni-tuebingen.de/~rguenth/