|
From: | Jeffrey D. Oldham |
Subject: | Re: [PATCH] Fix where breakage |
Date: | Tue, 30 Dec 2003 08:11:47 -0800 |
User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 |
Richard Guenther wrote:
Hi! With my recent where improvements I did some breakage which is obviously fixed by the following patch. I also extended array_test12 to contain some >1 dim tests. Regtested on the few where tests we have using serial ppc-linux. Ok to apply? Thanks, Richard. 2003Dec25 Richard Guenther <address@hidden> * Array/tests/array_test12.cpp: check systematically for d-dimensional array/scalar rhs in where. Evaluator/WhereProxy.h: use EvalLeaf of the dimensionality of the first where argument.
Thanks for fixing this. It would be nice if C++ permitted overloading '?:', but it does not so 'where' is important. Yes, please commit this after fixing the ChangeLog typo:
"Use EvalLeaf _on_ the dimensionality ..." -- Jeffrey D. Oldham address@hidden
[Prev in Thread] | Current Thread | [Next in Thread] |