gluster-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gluster-devel] [PATCH BUG:361 2/3] OS X: fnctl() flag FNM_EXTMATCH


From: Amar Tumballi
Subject: Re: [Gluster-devel] [PATCH BUG:361 2/3] OS X: fnctl() flag FNM_EXTMATCH is not supported under Mac OS X
Date: Tue, 28 Sep 2010 11:36:36 +0530



On Tue, Sep 28, 2010 at 1:18 AM, noah williamsson <address@hidden> wrote:
2010/9/27 Amar Tumballi <address@hidden>:
> How about having
>
> #define FNM_EXTMATCH 0
>
> in #ifdef DARWIN_OS section of 'libglusterfs/src/compat.h' file??
>
> Idea is to have as less as possible OS specific code inside core, and handle
> maximum possible things in compat.{c,h}
>

That would indeed be more elegant, however, given the fact that
FNM_EXTMATCH is a GNU fnmatch() extension, maybe it should be
considered to get rid of its use completely to get a consistent
behavior across different OSes?


That was thought of.. Will check with the team again, and resolve this. Better is to remove GNU specific flags from 'fnmatch()'.

-Amar

reply via email to

[Prev in Thread] Current Thread [Next in Thread]