|
From: | Amar Tumballi |
Subject: | Re: [Gluster-devel] glfs_init() not setting errno when volfile server is invalid |
Date: | Thu, 02 Aug 2012 11:30:59 +0530 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 |
On 08/02/2012 10:42 AM, Bharata B Rao wrote:
On Thu, Aug 2, 2012 at 8:16 AM, Anand Avati <address@hidden> wrote:I think this was fixed in http://review.gluster.com/#change,3732. Can you confirm?That commit doesn't fix this issue. I still see glfs_init() returning -1 with errno=0 when an invalid server is specified.
will below patch fix the issue? (very hacky, but prevents the qemu crash i guess)
diff --git a/api/src/glfs.c b/api/src/glfs.c index e81ae56..fecefea 100644 --- a/api/src/glfs.c +++ b/api/src/glfs.c @@ -530,6 +530,9 @@ glfs_init (struct glfs *fs) ret = glfs_init_wait (fs); + if (ret && !errno) + errno = EINVAL; + return ret; }
Regards, Bharata. _______________________________________________ Gluster-devel mailing list address@hidden https://lists.nongnu.org/mailman/listinfo/gluster-devel
[Prev in Thread] | Current Thread | [Next in Thread] |