[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Gluster-devel] how to reinstall a peer?
From: |
krish |
Subject: |
Re: [Gluster-devel] how to reinstall a peer? |
Date: |
Wed, 27 Feb 2013 17:22:14 +0530 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 02/27/2013 10:58 AM, Emmanuel Dreyfus wrote:
Emmanuel Dreyfus<address@hidden> wrote:
if (!xdr_string (xdrs, &objp->op_errstr, ~0))
return FALSE;
How is this supposed to work? Here is below the NetBSD xdr_string()
implementation from libc. Even if objp->op_errstr is not NULL, the
maxsize argument set to 0 will cause it to always retrurn false. Does it
has another semantic in Linux?
I overlooked it. ~0 is indeed not 0.
Hi Emmanuel,
I have attached a patch that should fix the glusterd crash on peer-probe.
xdr_string fails to serialize the supplied char * argument if it is
NULL. This
patch ensures that we supply a empty string when we don't have an actual
errstr to send across the wire.
Interestingly, in Linux glusterd didn't crash, but encoding the response
failed with
xdr_string failing to serialize a NULL string.
Could you raise a bug for this with the backtrace attached to it? That
would be handy to
push this patch.
thanks,
krish
0001-glusterd-Setting-errstr-to-to-appease-xdr_string.patch
Description: Text Data
- [Gluster-devel] how to reinstall a peer?, Emmanuel Dreyfus, 2013/02/25
- Re: [Gluster-devel] how to reinstall a peer?, Vijay Bellur, 2013/02/25
- Re: [Gluster-devel] how to reinstall a peer?, Emmanuel Dreyfus, 2013/02/25
- Re: [Gluster-devel] how to reinstall a peer?, Vijay Bellur, 2013/02/25
- Re: [Gluster-devel] how to reinstall a peer?, Emmanuel Dreyfus, 2013/02/25
- Re: [Gluster-devel] how to reinstall a peer?, Emmanuel Dreyfus, 2013/02/26
- Re: [Gluster-devel] how to reinstall a peer?, Emmanuel Dreyfus, 2013/02/27
- Re: [Gluster-devel] how to reinstall a peer?,
krish <=
- Re: [Gluster-devel] how to reinstall a peer?, Emmanuel Dreyfus, 2013/02/27
- Re: [Gluster-devel] how to reinstall a peer?, Krishnan Parthasarathi, 2013/02/27