gm2
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PATCH: Fix build when NULL == nullptr_t


From: Gaius Mulley
Subject: Re: PATCH: Fix build when NULL == nullptr_t
Date: Mon, 26 Apr 2021 11:46:59 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Brian Callahan <bcallah@protonmail.com> writes:

> Hello --
>
> As we previously discussed, there are potential build failures
> in the case where a system chooses to define NULL as nullptr_t
> when compiling C++11 or later. This is valid according to the
> C++ spec. However, it causes all sorts of GM2 build failures.
>
> The attached patch deals with this possibility and allows GM2
> to build correctly on these systems. I chose the solution of
> special-casing these systems, which is just OpenBSD at the
> moment but may expand to include other systems.
>
> The latest gm2-master builds and works correctly on OpenBSD
> with this.
>
> Thanks.
>
> ~Brian

Hello Brian,

Great thank you - all very cleanly implemented.
BTW do you have copyright assignment forms for GCC with the FSF?


regards,
Gaius



reply via email to

[Prev in Thread] Current Thread [Next in Thread]