Re: Ok I am stupid ( Segmentation fault with xgnokii Nokia 6310)

[Ulrich Hopp]

> > OK. The problem was introduced *after* 0.4.3. I suspect the following:
> >  * xgnokii updates:
> >     o remove unnecessary GSM_Data declarations         (Markus Plail)
> > Markus, could you elaborate on these changes? And maybe point the patch?
>
> OK. Fixed. The driver was writing some data the the some random pointer
> which was under data->Bitmap. Well, not fixed, but workarounded.
>
> The problem is with ugly gdat usage in xgnokii_lowlevel.c. It is declared
> as global static. It is nulled in the initializing function which is
> correct. But later in (almost) each function we do:
> void some_function(something)
> {
>       GSM_SomeField_in_GSM_Data something;
>
>       gdat.something = &something;
>       [...]
>       return;
> }
> After leaving this function the pointer is bogus. Quick fix would be to
> null GSM_Data pointers before quitting the function. The correct fix
> should start with the removal of the global gdat.
>
> Konstantinos, Ulrich, could you please test CVS?
CVS 12.08.2002
 works for me without errors
Uli