Re: A bug and sorta a fix

[Pawel Kot]

On Tue, 27 Aug 2002, Tor Petterson wrote:

> Pawel Kot wrote:
> > This is correct. In all Nokia phones you need to enable IrDA manually
> > before connecting. Some other phones are able to set IrDA permenently.
> > This is not a (gnokii) bug, this is a (Nokia) feature.
> you misunderstood me the problem is that if I start gnokii and it fails
> to connect in the first attempt it wont connect at all so:
> turn on irDA, start xgnokii works but
> start xgnokii, turn on irDA doesn't work so what I did was change
> if (error == GE_NOLINK)
> to
> if (error == GE_NOLINK || GE_NOTSUPPORTED)
> (this is in the funktion 'fbusinit' in xgnokii_lowlevel.c)
> but this is only partly a fix since error can have other values there aswell

Well, this loop doesn't look sane for me. See the attached patch. I'm not
commiting it because I'm not sure whether it is correct and whether it
works. Please test. Anyway it won't fix the connection per se, it will
just not attempt to reconnect.

pkot
-- 
mailto:address@hidden :: mailto:address@hidden
http://kt.linuxnews.pl/ :: Kernel Traffic po polsku