Re: Reviving 3110 support

[Osma Suominen]

Hello, sorry for the delay, I moved to Estonia during it, but now things
have settled down so I can continue my work with Gnokii :)

On Tue, 4 Feb 2003, Pawel Kot wrote:

> > * When saving SMS's, the location in memory can be specified. But the
> >   3110 doesn't allow this to be specified AFAIK. However, when it
> >   acknowledges a succesful send it tells which location the SMS was
> >   saved in. This is put by the driver into the gn_sms_raw struct. But it
> >   is not copied (by gsm-sms.c) back into the gn_sms struct, so e.g.
> >   command line gnokii reports that the SMS was stored in location 0. Is
> >   this a bug? I think other drivers (e.g. nk6100.c) also do the same.
>
> Yes, it is a bug. Would you provide a patch for gsm-sms.c?

Here's a oneline patch that fixes this little bug. You don't need to
include the comment if you don't like it. I tend to overcomment things.

-Osma

diff -u -r1.128 gsm-sms.c
--- common/gsm-sms.c    9 Feb 2003 22:04:53 -0000       1.128
+++ common/gsm-sms.c    12 Feb 2003 14:42:15 -0000
@@ -1346,6 +1346,10 @@
        }

        error = gn_sm_functions(GN_OP_SaveSMS, data, state);
+
+       /* the message was perhaps not stored at the specified location,
+          but the phone driver probably knows where, so copy it over */
+       data->sms->number = data->raw_sms->number;
 cleanup:
        data->raw_sms = NULL;
        return error;


-- 
*** Osma Suominen *** address@hidden *** http://www.iki.fi/ozone/ ***