gnokii-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch] Fix sending SMSes with certain phones.


From: David Vrabel
Subject: [patch] Fix sending SMSes with certain phones.
Date: Fri, 07 Jan 2005 13:36:33 +0000
User-agent: Mozilla Thunderbird 0.9 (X11/20041124)

Hi,

Certain phones do not store the leading '+' in phone numbers. This applies to the SMS message centre number and possibly other numbers.

e.g. With a Sony Ericcsson GM47 GSM module

at+csca="+4407802000332"
OK
at+csca?
+CSCA: "4407802000332",145
OK

char_semi_octet_pack() was unconditionally stripping the leading character (on international numbers). The attached patch causes only any leading '+' to be stripped.

David Vrabel

ps. Please CC; I'm not subscribed.
--
David Vrabel, Design Engineer

Arcom, Clifton Road           Tel: +44 (0)1223 411200 ext. 3233
Cambridge CB1 7EA, UK         Web: http://www.arcom.com/
--- gnokii-0.6.4/common/gsm-encoding.c  Sun Oct 17 20:44:20 2004
+++ gnokii-0.6.4/common/gsm-encoding.c.new      Fri Jan  7 11:57:14 2005
@@ -519,8 +519,7 @@
           only international and unknown number. */
 
        *out_num++ = type;
-       if (type == GN_GSM_NUMBER_International) in_num++; /* Skip '+' */
-       if ((type == GN_GSM_NUMBER_Unknown) && (*in_num == '+')) in_num++; /* 
Optional '+' in Unknown number type */
+       if (*in_num == '+') in_num++; /* skip any leading + */
 
        /* The next field is the number. It is in semi-octet representation - 
see
           GSM scpecification 03.40 version 6.1.0, section 9.1.2.3, page 31. */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]