Re: stupid bug in xgnokii phonebook editor

[Christoph Rudorff]

On 29.02.2012 10:23, Pawel Kot wrote:
>>> I think it is some old code that was introduced in order to support
>>> correctly EXTPBK when one number was stored only. At least some models
>>> required to replicate the main number as the subentry. I do not think
>>> we have cared about multiple subentries at that time.
>>
>> LoL. That said, it just works by accident?
>
> Sorry, do not get your point. What does work by accident?
>
>>>
>>>> xgnokii/xgnokii_contacts.c line 395 in EditPhonebookEntry()
>>>>
>>>> if (phoneMonitor.supported & PM_EXTPBK) {
>> ...
>>>> current_entry->entry.subentries[0].number_type = ...
>>>> current_entry->entry.subentries_count = 1;
>> ...
>>>
>>> That's plain simple. We're creating a subentry which is equal to the
>>> main number.

That is already done! (see OkEditNumbersDialog). The 1st subentry is
already set as main number.

>>>>
>>>> This block doesn't make sense.
>>>
>>> See above. Do not be easy on judgements.
>>>
>>>> Delete this block and the phone book works.
>>>
>>> What do you mean by "works" here? How would it keep other subentries?
>>>
>>> That's not enough as explained above.
>
> What if you have just one number?
>

Well, the code looks like it knows how to handle subentries.

It just looked stupid to me, that here the subentries_count is set to 1
and therefore ignoring the other entries and so they get lost.

>
>> Well, after some playing with the subentry types I noticed xgnoki doesn't
>> report about transfer errors except on stderr: e.g. A note may contain
>> chars and numbers not. But that's it ...
>
> You mean debug log or additional error information without debug log?

No, I mean if you fix the subentry issue, this leads then to another bug:
Transfer errors are silently ignored by the GUI. As a user, you just
wonder why some phone entries are missing on the real phone.

Create a phone book entry like this:

Name: test

subentries:
mobile: 99999988888
note: einpaarZeilen
fax: Thisgoeswrong

and transfer to phone:

Writing phonebook entry test...
Message sent: 0x03 / 0x0088
00 01 00 0b 00 01 01 00 00 10 02 05 00 0f 00 00 |
00 00 00 00 00 04 47 00 00 0e ff 08 00 74 00 65 |       G      t e
00 73 00 74 0b 00 00 20 ff 03 00 00 00 16 00 39 |  s t           9
00 39 00 39 00 39 00 39 00 39 00 38 00 38 00 38 |  9 9 9 9 9 8 8 8
00 38 00 38 0a 00 00 20 ff 1a 00 65 00 69 00 6e |  8 8       e i n
00 70 00 61 00 61 00 72 00 5a 00 65 00 69 00 6c |  p a a r Z e i l
00 65 00 6e 0b 00 00 24 ff 04 00 00 00 1a 00 54 |  e n   $       T
00 68 00 69 00 73 00 67 00 6f 00 65 00 73 00 77 |  h i s g o e s w
00 72 00 6f 00 6e 00 67                         |  r o n g
Message received: 0x03 / 0x000e
01 70 00 0c 00 01 0f 00 00 08 43 00 00 00       |  p        C
Received message type 03
response 0x10 error 0x43
Ereignis 3 schlug mit dem Rückgabewert 20 fehl!
xgnokii_contacts.c: line 2135: Can't write ME memory entry number 15!
Error: Datenformat ist nicht gültig.

So there it needs an error handling. Idea: mark the entry red in the gui?!

>
> take care,
> Paweł