Re: [Gnu-arch-users] [PATCH] arch speedups on big trees

[Tom Lord]

    > From: Andrew Suffield <address@hidden>

    >> Such optimizations require a fairly heavy proof before we can
    >> trust them: they must prove that the apply_changeset algorithm
    >> is invarient under them.  You haven't offered such a proof for
    >> your variation and, in fact, your proposal to specially
    >> consider only modified or deleted files is flat out wrong.

    > What's wrong with it?

Who knows the full list of things that are wrong with it but a subset
of that list includes consideration of adds (to avoid redundant adds)
and consideration of renames (both the things being renamed and their
(recursively) containing directories, bearing in mind that the
changeset is not guaranteed but is permitted to contain index entries
for those containing directories).

-t