gnu-arch-users
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnu-arch-users] Re: [PATCH] arch speedups on big trees


From: Chris Mason
Subject: [Gnu-arch-users] Re: [PATCH] arch speedups on big trees
Date: Thu, 08 Jan 2004 09:27:38 -0500

On Thu, 2004-01-08 at 09:16, Miles Bader wrote:
> On Thu, Jan 08, 2004 at 07:45:55AM -0500, Chris Mason wrote:
> > Because of arch_binary_files_differ(), diff is only going to get run
> > when the files are really different.  Using a pipe probably won't work,
> > since we'd need some way to deal with the case where diff is blocking
> > because the pipe is full.
> 
> The tla process should simply read the pipe (before waiting for the diff
> process) -- as soon as any output comes from it, open the output file, and
> start copying the pipe output to it; when the pipe gets an EOF, _then_ wait
> for the diff process.
> 

So as soon as the diff program makes output, we open the tmp file?

Because of arch_binary_files_differ(), we are 100% sure diff is going to
have output.  So just open the tmp file to start with and make life easy
;)

-chris






reply via email to

[Prev in Thread] Current Thread [Next in Thread]