[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Gnu-arch-users] FAI patches and feedback
From: |
David Allouche |
Subject: |
[Gnu-arch-users] FAI patches and feedback |
Date: |
Mon, 06 Sep 2004 23:15:36 +0200 |
Eventually, I gave a try to FAI.
Here are some patches for you:
Fai fai--devel--0> revisions --missing-from -s tagcur
address@hidden/fai--devel--0--base-0
tag of address@hidden/fai--devel--0--patch-171
address@hidden/fai--devel--0--patch-1
README points to pyarch--devo--0.1
address@hidden/fai--devel--0--patch-2
colorize='maybe'
address@hidden/fai--devel--0--patch-3
Fai fai--devel--0>
The patch-3 disable xterm set-title control codes on terminals which do
not support them.
It has no summary because I was bitten by a pretty annoying failure
mode:
Fai fai--devel--0> rm ++log.fai--d*
Fai fai--devel--0> commit
No log for this commit. Create now? [y/N] y
No editor specified.
Fai fai--devel--0> export EDITOR=emacsclient
get: invalid revision spec (EDITOR=emacsclient)
Fai fai--devel--0> \export EDITOR=emacsclient
Fai fai--devel--0> commit
M cmdutil.py
* committed address@hidden/fai--devel--0--patch-3
Apparently the first commit creates the log file and then fail without
removing it, and the second commit does no check that the log file has a
non-empty summary. I think commit should ask for a changelog if the
changelog summary is empty or whitespace only.
Also, there seems to be a problem with getting the help for some
commands. I was very confused by the code and did not figure how to fix
it.
tlash fai> fai shell
Fai fai--devel--0> help -h
Traceback (most recent call last):
File "/home/david/bin/fai", line 36, in ?
commands.find_command(sys.argv[1]).do_command(sys.argv[2:])
File "/home/david/home/devel/arch/fai/commands.py", line 1742, in
do_command
prompt.cmdloop()
File "/usr/lib/python2.3/cmd.py", line 133, in cmdloop
stop = self.onecmd(line)
File "/usr/lib/python2.3/cmd.py", line 210, in onecmd
return func(arg)
File "/home/david/home/devel/arch/fai/commands.py", line 1473, in
do_help
Help()(line)
File "/home/david/home/devel/arch/fai/commands.py", line 58, in
__call__
self.do_help()
AttributeError: Help instance has no attribute 'do_help'
tlash fai>
By the way, it would be nice if you added a simple make file with a
"make doc" or "make doxygen" target; I was not able to figure out how to
generate the doxygen documentation. Probably I could find it on the web,
but I was lazy and just try to fiddle around.
--
-- ddaa
- [Gnu-arch-users] FAI patches and feedback,
David Allouche <=