RE: Patch for Windows implementation of play-sound

[Ben Key]

I do have the newest MSSDK installed.  Therefore, I am not getting the
warnings you are getting.  However, if I do not define _WIN32_WINNT and
WINVER to be at least 0x0500 I get several compilation errors.

As for the section of emacs.c you mentioned, you a correct that that was an
unintentional change.  Tomorrow I will create a new diff to resolve that
problem.

-----Original Message-----
From: Juanma Barranquero [mailto:address@hidden
Sent: Wednesday, October 16, 2002 12:34 PM
To: address@hidden
Cc: address@hidden; address@hidden
Subject: Re: Patch for Windows implementation of play-sound


On Wed, 16 Oct 2002 00:04:34 -0400, "Ben Key" <address@hidden> wrote:

> I have also tested this
> patch with Microsoft Visual C++ 6.0 and MinGW 2.0 / MSys 1.08.

Do you have a recent SDK from msdn.microsoft.com? The -DWINVER=0x0501
gives me about a gazillion of those:

> NOTE: WINVER has been defined as 0x0500 or greater which enables
> Windows NT 5.0 and Windows 98 features. When these headers were released,
> Windows NT 5.0 beta 1 and Windows 98 beta 2.1 were the current versions.
>
> For this release when WINVER is defined as 0x0500 or greater, you can only
> build beta or test applications.  To build a retail application,
> set WINVER to 0x0400 or visit http://www.microsoft.com/msdn/sdk
> to see if retail Windows NT 5.0 or Windows 98 headers are available.
>
> See the SDK release notes for more information.


Also, is this bit from src/emacs.c intended, or did you cvs diff and
accidentally got this reversed?

> @@ -2302,13 +2302,11 @@
>                doc: /* Non-nil means Emacs is running without interactive
terminal.  */);
>
>    DEFVAR_LISP ("kill-emacs-hook", &Vkill_emacs_hook,
> -              doc: /* Hook to be run when kill-emacs is called.
> -Since `kill-emacs' may be invoked when the terminal is disconnected (or
> +              doc: /* Hook to be run whenever kill-emacs is called.
> +Since kill-emacs may be invoked when the terminal is disconnected (or
>  in other similar situations), functions placed on this hook should not
>  expect to be able to interact with the user.  To ask for confirmation,
> -see `kill-emacs-query-functions' instead.
> -
> -The hook is not run in batch mode, i.e., if `noninteractive' is non-nil.
*/);
> +see `kill-emacs-query-functions' instead.  */);
>    Vkill_emacs_hook = Qnil;
>
>    empty_string = build_string ("");


                                                           /L/e/k/t/u