gnuastro-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #61128] Radial profile script's --instd doesn't work without equal


From: Mohammad Akhlaghi
Subject: [bug #61128] Radial profile script's --instd doesn't work without equal sign
Date: Thu, 23 Sep 2021 19:04:03 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Firefox/92.0

Update of bug #61128 (project gnuastro):

                  Status:                    None => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #3:

The branch has been merged into 'master' as Commits 8b964027e
<https://git.savannah.gnu.org/cgit/gnuastro.git/commit/?id=8b964027e> and
2b10e4c6b
<https://git.savannah.gnu.org/cgit/gnuastro.git/commit/?id=2b10e4c6b>, so I am
closing the bug.

Thanks a lot Sepideh for finding and fixing this bug, and welcome to the club
of Gnuastro authors/committers: You are now on the first page of the PDF
manual <https://akhlaghi.org/gnuastro.pdf>. I am sure you will make many more
commits and improve Gnuastro for yourself and everyone else :-).

Also thanks a lot Raul for inspecting/improving it and for adding the
documentation :-).

Just a few small points on both commits (they have been modified before the
merging with 'master'):

Sepideh (compare with your original commit in your own Gitlab):
* When you want to specify coding names within English text, use an apostrophe
(') before and after the word. You had used the grave accent
<https://en.wikipedia.org/wiki/Grave_accent> (`). This is a common mistake
because webpages like Gitlab, Codeberg or Github use it to typeset code in a
different format. But that is only for the issues in those services, it
doesn't apply to commit messages. So its safer to always use an apostrophe in
commit messages or code and leave the grave accent for web-based issues.
* You had started your second paragraph with "Now ...", but it should be "With
this commit ...".

Raul:
* In Texinfo, when multiple options have the same description, the first
(usually the short option) is written as '@item', while second (and later)
options should be written as '@itemx'. This will tell Texinfo that the
'@itemx' is related to the '@item' and thus it will put less space between
them (helping the reader associate them as one). However, if you simply put a
new '@item' after a previous '@item', Texinfo will put more space because it
thinks you are introducing a whole new option. 
* In your edits to Sepideh's commit, I noticed that you had removed the
'instdhduopt' option (which would remove the '--hdu' option when '--stdhdu'
wasn't given). However, the 'stdhdu' variable in the shell had not been
initialized to '1'. So if the user gave a standard deviation image, but didn't
give '--stdhdu' Crop would crash. To fix it, I just initialized 'stdhdu' to
'1' as soon as we define it.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61128>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]