[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #61287] Two switch blocks miss "break" in their branches
From: |
Vladimir Markelov |
Subject: |
[bug #61287] Two switch blocks miss "break" in their branches |
Date: |
Mon, 4 Oct 2021 22:17:11 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:92.0) Gecko/20100101 Firefox/92.0 |
URL:
<https://savannah.gnu.org/bugs/?61287>
Summary: Two switch blocks miss "break" in their branches
Project: GNU Astronomy Utilities
Submitted by: vvm
Submitted on: Пн 04 окт 2021 19:17:09
Category: MakeCatalog
Severity: 3 - Normal
Item Group: Source code
Status: None
Privacy: Public
Assigned to: None
Open/Closed: Open
Discussion Lock: Any
_______________________________________________________
Details:
It seems makecatalog's columns.c misses "break" in a couple of places. I do
not think fallthrough there is intended:
makecatalog/columns.c
2825 case UI_KEY_GEOZ:
2826 ((float *)colarr)[cind] = MKC_RATIO( ci[CCOL_GZ],
2827 ci[CCOL_NUMALL] );
2828 // I think "break" should be here
2829 case UI_KEY_MINVX:
2830 ((float *)colarr)[cind] = MKC_RATIO( ci[CCOL_MINVX],
ci[CCOL_MINVNUM] );
2831 break;
and this one
2443 case UI_KEY_CLUMPSGEOZ:
2444 ((float *)colarr)[oind] = MKC_RATIO( oi[OCOL_C_GZ],
2445 oi[OCOL_C_NUMALL] );
2446 // I think "break" should be here
2447 case UI_KEY_MINVX:
2448 ((float *)colarr)[oind] = MKC_RATIO( oi[OCOL_MINVX],
oi[OCOL_MINVNUM] );
2449 break;
-verbatim
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?61287>
_______________________________________________
Сообщение отправлено по Savannah
https://savannah.gnu.org/
- [bug #61287] Two switch blocks miss "break" in their branches,
Vladimir Markelov <=