gnuastro-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug #61476] astscript-ds9-region makes output even when no input given


From: Mohammad Akhlaghi
Subject: [bug #61476] astscript-ds9-region makes output even when no input given
Date: Thu, 1 Feb 2024 18:06:59 -0500 (EST)

Update of bug#61476 (group gnuastro):

                  Status:                    None => Fixed                  
             Assigned to:                    None => alteholz               
             Open/Closed:                    Open => Closed                 
                 Summary: In 'astscript-ds9-region' the out put should not be
created, when the input does not exist => astscript-ds9-region makes output
even when no input given

    _______________________________________________________

Follow-up Comment #3:

Thanks a lot Thorsten, your (modified) commit has been merged into the
'master' branch as
[https://git.savannah.gnu.org/cgit/gnuastro.git/commit/?id=9e3c4f94 Commit
9e3c4f94]. Here are some notes for future commits:
* Gnuastro's commit messages should be very descriptive, fully describing the
problem first, then the solution. As if it was an email for someone only
looking at the commit messages. In the
[https://www.gnu.org/software/gnuastro/manual/html_node/Developing.html
Developing] chapter, we have a full description of the
[https://www.gnu.org/software/gnuastro/manual/html_node/Commit-guidelines.html
Commit guidelines]. The merged commit above can be a nice example ;-).
* Within the code, all lines should be less than 75 characters. You can see
the
[https://www.gnu.org/software/gnuastro/manual/html_node/Coding-conventions.html
Coding conventions] for more on such conventions. It was because of this that
I broke the long line into multiple lines.

Thanks again for fixing this bug :-).


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61476>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]