[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gnugo-devel] disconnect crash (was dynamic connection status)

From: Daniel Bump
Subject: Re: [gnugo-devel] disconnect crash (was dynamic connection status)
Date: Fri, 18 Jan 2002 15:42:31 -0800

Gunnar wrote:

> The logic in the komaster == GRAY case is simply wrong but I don't
> have a solution available. Until someone can come up with a fix for
> this I suggest we change KOMASTER_SCHEME to 2 or 3.

This logic is OK. But there was a bug in komaster_trymove. 

The ko point didn't get moved when the ko was taken unless komaster was
color. This looks clearly wrong and in Gunnar's example led to a mismatch
between the ko point and the actual location of the last ko taken after 
B:E7 W:F7 B:E9. Because of this the ko appeared (wrongly) to have been
resolved and the komaster reverted to EMPTY.

This patch also fixes the crash Trevor reported. It doesn't
break anything in reading.tst but I'll hold off until I've run
more regressions before putting it in the CVS.


Index: engine/board.c
RCS file: /cvsroot/gnugo/gnugo/engine/board.c,v
retrieving revision 1.27
diff -u -r1.27 board.c
--- engine/board.c      3 Jan 2002 21:17:38 -0000       1.27
+++ engine/board.c      18 Jan 2002 23:26:02 -0000
@@ -1032,8 +1032,7 @@
   if (komaster == other)
     *new_komaster = GRAY;
-  else if (komaster == color)
-    *new_kom_pos = kpos;
+  *new_kom_pos = kpos;
   return 1;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]