[gnugo-devel] Owl threats

[Daniel Bump]

Previously I put up a patch called owl_threats_1_22.1 which
made the owl threat computation optional. I added this
to the CVS.

Taking out the owl threat computation gives a very
substantial speedup. It does break some regressions.

The version I tested it on omits some patches that are now
in the CVS so you probably won't get identical results.
I ran two similarly patched GNU Go processes and with
the owl threats disabled we got 74 PASS and 42 FAIL
where the version which computed the owl threats gave
59 PASS and 16 FAIL.

There is a net loss of 11 tests. So if you have a fast
machine, you should consider compiling with
--enable-owl-threats. But for on the whole, I don't
think the owl threats are cost effective at current
speeds.

I'm attaching a record of the differences between the
test results.

One motivation I have for making the owl threats
optional is that I want to make the new semeai code
standard soon. I'm working on implementing Zobrist
hashing for it. If I can get this working I think
the semeai code will be useful enough to make standard.

Dan

--- compiled with owl threats
+++ compiled without owl threats
@@ -1,121 +1,162 @@
 ./regress.sh . reading.tst
 ./regress.sh . owl.tst
 230 unexpected FAIL: Correct '0', got '1 H6'
 255 unexpected PASS!
 ./regress.sh . owl_rot.tst
 150 unexpected PASS!
 ./regress.sh . ld_owl.tst
 193 unexpected PASS!
 199 unexpected PASS!
 ./regress.sh . optics.tst
 ./regress.sh . filllib.tst
 ./regress.sh . atari_atari.tst
 13 unexpected PASS!
 ./regress.sh . connection.tst
 ./regress.sh . blunder.tst
 ./regress.sh . strategy.tst
+6 unexpected PASS!
 20 unexpected PASS!
+34 unexpected FAIL: Correct 'E17', got 'N15'
+44 unexpected FAIL: Correct 'G2', got 'J2'
 ./regress.sh . endgame.tst
 ./regress.sh . heikki.tst
 ./regress.sh . neurogo.tst
+7 unexpected PASS!
 ./regress.sh . arb.tst
 ./regress.sh . rosebud.tst
 ./regress.sh . golife.tst
 ./regress.sh . arion.tst
 ./regress.sh . viking.tst
 8 unexpected PASS!
 ./regress.sh . ego.tst
-8 unexpected PASS!
 ./regress.sh . dniwog.tst
 5 unexpected PASS!
 ./regress.sh . lazarus.tst
-2 unexpected FAIL: Correct 'M4', got 'P6'
+2 unexpected FAIL: Correct 'M4', got 'C6'
 10 unexpected PASS!
-14 unexpected FAIL: Correct 'Q15|T5|H5', got 'H3'
-16 unexpected PASS!
 17 unexpected PASS!
 ./regress.sh . strategy2.tst
 60 unexpected FAIL: Correct 'H7', got 'K14'
+70 unexpected FAIL: Correct 'M15|J15|N16|J16', got 'C15'
 73 unexpected PASS!
-80 unexpected PASS!
+78 unexpected FAIL: Correct 'H2', got 'B14'
+84 unexpected FAIL: Correct 'Q13', got 'G5'
 ./regress.sh . nicklas1.tst
+502 unexpected PASS!
+1206 unexpected FAIL: Correct 'C15', got 'N10'
+1214 unexpected PASS!
 ./regress.sh . nicklas2.tst
 ./regress.sh . nicklas3.tst
+1403 unexpected FAIL: Correct 'J6|H9', got 'H1'
 ./regress.sh . nicklas4.tst
 ./regress.sh . nicklas5.tst
 ./regress.sh . manyfaces.tst
 ./regress.sh . niki.tst
 ./regress.sh . trevor.tst
+15 unexpected FAIL: Correct 'E7', got 'C6'
+160 unexpected PASS!
 411 unexpected PASS!
 ./regress.sh . tactics.tst
 ./regress.sh . buzco.tst
 ./regress.sh . nngs.tst
 250 unexpected PASS!
 260 unexpected FAIL: Correct 'O13|P14', got 'E2'
+320 unexpected FAIL: Correct 'B15|B16', got 'D17'
+330 unexpected FAIL: Correct 'B15|B16', got 'D15'
+380 unexpected PASS!
 420 unexpected PASS!
 440 unexpected PASS!
 510 unexpected FAIL: Correct 'G14', got 'G13'
-560 unexpected PASS!
 610 unexpected PASS!
+680 unexpected PASS!
 930 unexpected FAIL: Correct 'S8', got 'R17'
+1020 unexpected FAIL: Correct 'Q2', got 'P2'
 1030 unexpected PASS!
 1040 unexpected PASS!
 1070 unexpected PASS!
 1080 unexpected PASS!
 1110 unexpected PASS!
 1120 unexpected PASS!
 1550 unexpected PASS!
 1660 unexpected PASS!
 1860 unexpected PASS!
 1870 unexpected PASS!
-1955 unexpected PASS!
 1980 unexpected PASS!
 ./regress.sh . strategy3.tst
+119 unexpected FAIL: Correct 'D9|J3', got 'B10'
 ./regress.sh . capture.tst
 ./regress.sh . connect.tst
 ./regress.sh . global.tst
+5 unexpected FAIL: Correct 'O4', got 'F5'
 7 unexpected PASS!
+9 unexpected FAIL: Correct 'F4', got 'J9'
 10 unexpected PASS!
+16 unexpected PASS!
+33 unexpected FAIL: Correct 'Q9', got 'F15'
 37 unexpected PASS!
 ./regress.sh . vie.tst
 ./regress.sh . arend.tst
+3 unexpected FAIL: Correct 'P6|Q5', got 'Q7'
+5 unexpected FAIL: Correct 'D7|E7|E6', got 'F3'
 29 unexpected FAIL: Correct 'B14|C14', got 'C15'
 30 unexpected PASS!
 ./regress.sh . 13x13.tst
 17 unexpected PASS!
 29 unexpected PASS!
 33 unexpected FAIL: Correct 'E7', got 'E8'
+42 unexpected FAIL: Correct 'N3|N2|L4|L3|L2|L1|M1|N1|M3', got 'C7'
+52 unexpected FAIL: Correct 'H10', got 'N9'
 77 unexpected FAIL: Correct 'L6|K5', got 'B12'
 ./regress.sh . trevora.tst
 460 unexpected PASS!
+470 unexpected FAIL: Correct '!E2', got 'E2'
 560 unexpected FAIL: Correct '!B4', got 'B4'
 ./regress.sh . trevorb.tst
 220 unexpected PASS!
 300 unexpected FAIL: Correct 'F2', got 'F13'
+370 unexpected FAIL: Correct 'L7', got 'B10'
+500 unexpected PASS!
+570 unexpected FAIL: Correct 'N9', got 'E8'
+740 unexpected PASS!
 880 unexpected PASS!
-960 unexpected PASS!
+950 unexpected PASS!
 ./regress.sh . trevorc.tst
+160 unexpected PASS!
 270 unexpected PASS!
 300 unexpected PASS!
 440 unexpected PASS!
+510 unexpected PASS!
+520 unexpected PASS!
 550 unexpected PASS!
 570 unexpected PASS!
+590 unexpected FAIL: Correct '!G9', got 'G9'
 800 unexpected PASS!
 880 unexpected PASS!
 890 unexpected PASS!
 1000 unexpected PASS!
 1030 unexpected PASS!
 1080 unexpected PASS!
+1090 unexpected FAIL: Correct '!E1', got 'E1'
+1170 unexpected PASS!
+1540 unexpected PASS!
+1600 unexpected PASS!
+1680 unexpected PASS!
 ./regress.sh . trevord.tst
 310 unexpected PASS!
 330 unexpected PASS!
+360 unexpected PASS!
 370 unexpected FAIL: Correct '!J9', got 'J9'
+560 unexpected PASS!
+600 unexpected FAIL: Correct 'L14', got 'N12'
 830 unexpected FAIL: Correct '!G6|E6', got 'E6'
-950 unexpected FAIL: Correct 'R9', got 'H2'
 980 unexpected PASS!
 ./regress.sh . semeai.tst
 ./regress.sh . strategy4.tst
 156 unexpected PASS!
 163 unexpected PASS!
 166 unexpected PASS!
 182 unexpected FAIL: Correct 'E7|F8', got 'C14'
+183 unexpected FAIL: Correct 'P10|H9', got 'Q12'
+194 unexpected PASS!
+202 unexpected FAIL: Correct 'B6', got 'D5'
+205 unexpected FAIL: Correct '!O11', got 'O11'