[gnugo-devel] experimental connections

[Gunnar Farneback]

There is an experimental-connections configure and runtime option
which turns on the use of the readconnect module by the rest of the
engine. This is actually limited to whether the play_connect() family
of autohelper functions call readconnect or just make a pessimistic
guess. The option is currently on by default and has been since before
3.2. I think it's time to let the connection autohelpers use
readconnect unconditionally and reset the default for
experimental-connections to off, in preparation for new connection
experiments. This patch definitely does the first and hopefully also
the second (not sure of the correctness though).

- play_connect_n() uses string_connect() and disconnect()
  unconditionally, no longer contingent on experimental_connections
- default value for experimental_connections reset to 0

/Gunnar

Index: configure.in
===================================================================
RCS file: /cvsroot/gnugo/gnugo/configure.in,v
retrieving revision 1.52
diff -u -r1.52 configure.in
--- configure.in        16 May 2002 09:02:29 -0000      1.52
+++ configure.in        16 May 2002 19:25:25 -0000
@@ -414,10 +414,10 @@
 AH_TEMPLATE([EXPERIMENTAL_CONNECTIONS],
 [Connection module. Default standard.])
 
-if test "$enable_experimental_connections" = "no" ; then
-   AC_DEFINE(EXPERIMENTAL_CONNECTIONS, 0)
-else
+if test "$enable_experimental_connections" = "yes" ; then
    AC_DEFINE(EXPERIMENTAL_CONNECTIONS, 1)
+else
+   AC_DEFINE(EXPERIMENTAL_CONNECTIONS, 0)
 fi
 
 dnl ------------ Connections -------------------
Index: engine/utils.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/engine/utils.c,v
retrieving revision 1.47
diff -u -r1.47 utils.c
--- engine/utils.c      16 May 2002 09:07:48 -0000      1.47
+++ engine/utils.c      16 May 2002 19:25:25 -0000
@@ -462,12 +462,6 @@
   int ypos;
   int zpos;
 
-  /* FIXME: very pessimistic approach if connections module not
-   * included. */
-  if (!experimental_connections) {
-    return do_connect;
-  }
-
   va_start(ap, num_moves);
 
   /* Do all the moves with alternating colors. */