[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gnugo-devel] final patch, first version

From: Arend Bayer
Subject: Re: [gnugo-devel] final patch, first version
Date: Sun, 8 Sep 2002 16:49:00 +0200 (CEST)

I had just tried out your patch -- quick remarks in addition to Gunnar's:
With gcc, I get warnings:
Tons of those:
In file included from read_defend.c:23:
../engine/liberty.h:592: warning: function declaration isn't a prototype
(gcc wants "void" in the parameter list if there is no parameter)

And this one:
play_solo.c: In function `load_and_analyze_sgf_file':
play_solo.c:156: warning: unused variable `r'
play_solo.c:152: warning: unused parameter `benchmark'

Also, I tried
gnugo -l games/handtalk/handtalk12.sgf -L 102 --printsgf xx.sgf
and get
- valid output with 3.2
- broken output with CVS
- no output with CVS+your patch

About gtp_finish_sgftrace: I use this frequently for debugging, I guess
Gunnar, too, and the filename is really necessary.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]