[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gnugo-devel] engine/influence.c
From: |
Arend Bayer |
Subject: |
Re: [gnugo-devel] engine/influence.c |
Date: |
Mon, 23 Sep 2002 12:16:50 +0200 (CEST) |
On 23 Sep 2002, Dave Denholm wrote:
> > > > Profile of cvs:
> > > > time seconds seconds calls ms/call ms/call name
> > > > 10.57 7.82 7.82 21833 0.36 0.36
> > > > accumulate_influence
> > > >
> > > > Profile with this change:
> > > > 22.31 17.24 17.24 23074 0.75 0.75
> > > > accumulate_influence
> > > >
> > > > In other words, we should do s.th. about the performance.
> > >
>
> > I've applied the patch by hand to CVS -- I had to remove the hard-coding
> > of DIAGONAL_DAMPING and also added one other micro-speedup (now we test
> > first whether the permeability is 0.0 before we even start the inner
> > loop). It's a good improvement over the simple bugfix, but still
> > a lot worse than CVS:
> >
> > time seconds seconds calls ms/call ms/call name
> > 17.03 13.64 13.64 24374 0.56 0.56 accumulate_influence
> >
> > In my opinion 10% is already too much time for this function.
> >
>
>
> Is this with unrolling on or off ?
>
> It had been my intention that adding both the do ... while(0) around the
> macro and changing the order of the invocations of the macro should make
> the two cases identical. So it should no longer be necessary to turn off
> loop unrolling.
>
> And then getting rid of the divisions was an additional speedup.
That is with loop unrolling on. The speedup from 22.31 to 17.03 seconds
is due to your speedups. The slow-down compared to 10.57 is due to the
bug fix, which means actually doing more work.
Arend
- Re: [gnugo-devel] engine/influence.c (and DFA), (continued)
- Re: [gnugo-devel] engine/influence.c (and DFA), Arend Bayer, 2002/09/12
- Re: [gnugo-devel] engine/influence.c (and DFA), Dave Denholm, 2002/09/12
- Re: [gnugo-devel] engine/influence.c (and DFA), Arend Bayer, 2002/09/12
- Re: [gnugo-devel] engine/influence.c, Arend Bayer, 2002/09/20
- Re: [gnugo-devel] engine/influence.c, Gunnar Farneback, 2002/09/21
- Re: [gnugo-devel] engine/influence.c, Arend Bayer, 2002/09/23
- Re: [gnugo-devel] engine/influence.c, Arend Bayer, 2002/09/24
- Re: [gnugo-devel] engine/influence.c, Dave Denholm, 2002/09/23
- Re: [gnugo-devel] engine/influence.c,
Arend Bayer <=