[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [gnugo-devel] owl_determine_life() patch

From: Gunnar Farneback
Subject: Re: [gnugo-devel] owl_determine_life() patch
Date: Fri, 15 Nov 2002 17:31:58 +0100
User-agent: EMH/1.14.1 SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.3 Emacs/20.7 (sparc-sun-solaris2.7) (with unibyte mode)

Paul wrote:
> this patch looks like a logical bugfix to me. it changes evaluation of
> *eyemax in owl_determine_life() and, hence, the condition to disable
> playing vital moves. regression delta is quite neutral: 4 passes, 3
> fails.

The old code looked like this:

    for (ne = 0; ne < num_eyes - num_lunch; ne++) {
      add_eyevalues(probable_eyes, &eyevalue_list[ne], probable_eyes);
      *eyemax += max_eyes(probable_eyes);

The *eyemax computation is indeed horribly wrong. It should have been

      *eyemax += max_eyes(@eyevalue_list[ne]);

in order to make sense. (The bug was introduced in one of my patches.
It seeems you need to review those harder. :-)

Your patch looks okay too. I've added it to CVS.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]